Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation] Fixing cukes due to new navigation features #77

Merged
merged 3 commits into from
Oct 3, 2018

Conversation

didierofrivia
Copy link
Member

What this PR does / why we need it:

Fixing capybara JS errors in cukes for PF3 header

Which issue(s) this PR fixes

Special notes for your reviewer:

@didierofrivia didierofrivia self-assigned this Oct 2, 2018
@didierofrivia didierofrivia force-pushed the fix-cukes branch 3 times, most recently from 6e7eb56 to d8019e3 Compare October 3, 2018 10:52
@didierofrivia didierofrivia changed the title [navigation] using babel polyfill [navigation] Fixing cukes due to new navigation features Oct 3, 2018
@didierofrivia didierofrivia force-pushed the fix-cukes branch 3 times, most recently from a150ea8 to 39aad91 Compare October 3, 2018 20:54
[navigation] not exposing $

* multiple jQuery libs... way too many there

[packs] using core-js modules instead of babel-polyfill

[cuke] Using selenium driver for policy chain feature

[cuke] Fixing dashboard link

[cuke] managing feature executed w/o selenium driver

[cuke] settings feature with selenium

[cuke] adding ajax to the salad

[navigation] Don't toggle when it's a search box
* Failing, but manually tested
* This will be reverted once we found the *why*
@didierofrivia didierofrivia merged commit 0fdc7a8 into pf3-styled-header Oct 3, 2018
@didierofrivia didierofrivia deleted the fix-cukes branch October 3, 2018 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant