New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example sketch for half-duplex RS485 #66

Merged
merged 2 commits into from Sep 11, 2016

Conversation

Projects
None yet
2 participants
@kintel
Contributor

kintel commented Sep 11, 2016

Follow-up to #44.

Note: This has not yet been tested on actual hardware, but feel free to review code in the meantime.

TODO:

  • Style fixes
  • Test on actual hardware
@4-20ma

This comment has been minimized.

Show comment
Hide comment
@4-20ma

4-20ma Sep 11, 2016

Owner

@kintel thanks for the half-duplex example. Looks pretty good. I've annotated a few lines with minor style issues (line length, brace position). Ready to merge after updates.

Owner

4-20ma commented Sep 11, 2016

@kintel thanks for the half-duplex example. Looks pretty good. I've annotated a few lines with minor style issues (line length, brace position). Ready to merge after updates.

@4-20ma 4-20ma merged commit f032345 into 4-20ma:master Sep 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@4-20ma

This comment has been minimized.

Show comment
Hide comment
@4-20ma

4-20ma Sep 11, 2016

Owner

LGTM. I'm going to merge this so I can finish adjusting license text. Open a separate issue/PR if the hardware test reveals a bug.

Owner

4-20ma commented Sep 11, 2016

LGTM. I'm going to merge this so I can finish adjusting license text. Open a separate issue/PR if the hardware test reveals a bug.

@4-20ma 4-20ma changed the title from Added half duplex RS485 example to Add example sketch for half-duplex RS485 Sep 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment