Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Table 実装 #723

Merged
merged 7 commits into from
Aug 18, 2022
Merged

feat: Table 実装 #723

merged 7 commits into from
Aug 18, 2022

Conversation

locona
Copy link
Contributor

@locona locona commented Aug 16, 2022 •
edited
Loading

@vercel
Copy link

vercel bot commented Aug 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
3design-ui ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 8:38AM (UTC)
3design-ui-example ❌ Failed (Inspect) Aug 18, 2022 at 8:38AM (UTC)
3design-ui-v1 ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 8:38AM (UTC)
3design-ui-v3 ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 8:38AM (UTC)

@locona locona self-assigned this Aug 16, 2022
@locona locona requested a review from Qs-F August 16, 2022 04:46
@github-actions github-actions bot added the feat label Aug 16, 2022
@vercel vercel bot temporarily deployed to Preview – 3design-ui-v3 August 16, 2022 04:47 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui August 16, 2022 04:47 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui-v1 August 16, 2022 04:48 Inactive
Qs-F
Qs-F requested changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@Qs-F Qs-F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

borderの色だけであとは大丈夫そうです！

Scrollerの例、v2ではheaderをfixedにしてたっぽいですがそれは意図的にはずしたであってますか？

src/table/Table.tsx Outdated Show resolved Hide resolved
@locona @Qs-F
Update src/table/Table.tsx
f78d6ed 
Co-authored-by: たふみ <qsf@de-liker.com>
@vercel vercel bot temporarily deployed to Preview – 3design-ui-example August 18, 2022 04:00 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui August 18, 2022 04:02 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui-v1 August 18, 2022 04:02 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui-v3 August 18, 2022 04:02 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui-example August 18, 2022 04:55 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui-v3 August 18, 2022 04:57 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui August 18, 2022 04:57 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui-v1 August 18, 2022 04:57 Inactive
@locona
Copy link
Contributor Author

locona commented Aug 18, 2022

@Qs-F
54f5748#diff-b63cc1d680b7dadb966abac3b31f61e08e9eb1c03dfb910be3770648d42af541R11

こちらで対応しました

@vercel vercel bot temporarily deployed to Preview – 3design-ui-example August 18, 2022 07:22 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui August 18, 2022 07:24 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui-v3 August 18, 2022 07:24 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui-v1 August 18, 2022 07:24 Inactive
Qs-F
Qs-F requested changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@Qs-F Qs-F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/3-shake/3design-ui/blob/999dff025f2e89b48388d55ae1f45ca6aa52b081/src/table/Table.tsx#L190

すみません、ここも border-shade-light-default でお願いします！あと tr につけているためかスクロールしたときに線も上に行ってしまうので、固定したいです！

@vercel vercel bot temporarily deployed to Preview – 3design-ui-v3 August 18, 2022 08:33 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui-v1 August 18, 2022 08:33 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui-example August 18, 2022 08:33 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui-example August 18, 2022 08:35 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui-v3 August 18, 2022 08:38 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui-v1 August 18, 2022 08:38 Inactive
@vercel vercel bot temporarily deployed to Preview – 3design-ui August 18, 2022 08:38 Inactive
Qs-F
Qs-F approved these changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@Qs-F Qs-F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

完璧です！ありがとうございます！ (border-separate なんてものがあるんですね… すごい…)

@locona locona merged commit 4ae8a94 into v3 Aug 18, 2022
@locona locona deleted the feat/table branch August 18, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qs-F Qs-F Qs-F approved these changes

Assignees

@locona locona

Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@locona @Qs-F