This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📊 Metadata *
Bounty URL: https://www.huntr.dev/bounties/1-npm-httpster
⚙️ Description *
The
httpster
file server was vulnerable against apath traversal
issue which existed becausesymlinks
were fetched and their content served without any warn/error.💻 Technical Description *
I inserted a
new router
inside theexpress
server which was created byhttpster
and usedfs.lstat
to check if the requested file is or not asymlink
.In case it is and the
--symlink
flag isn't specified by the server (defaultfalse
like in other servers likeNginx
), an error is thrown.🐛 Proof of Concept (PoC) *
httpster
ln -s /etc/passwd test
httpster
/etc/passwd
file is shown🔥 Proof of Fix (PoF) *
/etc/passwd
filehttpster --symlink
and the/etc/passwd
file is shown (option)👍 User Acceptance Testing (UAT)
All ok 😄