Upgraded to Java 11 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis needs to be updated to Java 11 as well. See the failed CI builds in this PR |
|
What is Travis and how do I upgrade it? |
|
It’s the build system used on GitHub. See https://travis-ci.org/42BV/heph/builds/577188512?utm_source=github_status&utm_medium=notification and notice where it says oracle jdk 8 at the bottom. That should be set to 11 in Line 4 in 85c8f69 |
RubberDuckJordi
force-pushed
the
feature/java-11
branch
from
67f5ce5
to
57182f0
Compare
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
============================================
- Coverage 84.44% 82.63% -1.81%
- Complexity 111 118 +7
============================================
Files 12 12
Lines 315 334 +19
Branches 45 48 +3
============================================
+ Hits 266 276 +10
- Misses 23 32 +9
Partials 26 26
Continue to review full report at Codecov.
|
RubberDuckJordi
force-pushed
the
feature/java-11
branch
from
57182f0
to
ee573db
Compare
Closed
Java 8 is no longer supported in this version! The previous way of reflection used in BuildCommandAdvice is no longer working in Java 11. This has been replaced with a way that does work. Setting Arrays also no longer worked. A field of type String[] could no longer be filled with an Object[] as was possible in Java 8. This bit has been improved to fill the field with a String[]. The code detects of what type the field is and creates an Array of said type accordingly, keeping this dynamic for all types of arrays.
RubberDuckJordi
force-pushed
the
feature/java-11
branch
from
ee573db
to
bcc3958
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 8 is no longer supported in this version!
The previous way of reflection used in BuildCommandAdvice is no longer
working in Java 11. This has been replaced with a way that does work.
Setting Arrays also no longer worked. A field of type String[] could
no longer be filled with an Object[] as was possible in Java 8. This
bit has been improved to fill the field with a String[]. The code
detects of what type the field is and creates an Array of said type
accordingly, keeping this dynamic for all types of arrays.