Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now automatically retrieves a JpaRepository for the given entity class #7

Merged

Conversation

arjanvlek
Copy link
Contributor

When creating a BuildCommand, it is no longer required to override the
method getRepository(). The repository is now looked up using the
Repositories class from the Spring Framework.

If no repository is available, the builder still works. You can also
still override the getRepository() method in your buildCommand to
return a customized repository instance (or disable the repository on
purpose)

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #7 into feature/code-generation will decrease coverage by 0.49%.
The diff coverage is 81.25%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##             feature/code-generation       #7     +/-   ##
============================================================
- Coverage                      86.95%   86.46%   -0.5%     
- Complexity                        47       54      +7     
============================================================
  Files                              6        6             
  Lines                            115      133     +18     
  Branches                           9       11      +2     
============================================================
+ Hits                             100      115     +15     
- Misses                             8        9      +1     
- Partials                           7        9      +2
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/nl/_42/heph/AbstractBuildCommand.java 90.19% <100%> (+1.55%) 24 <4> (+4) ⬆️
src/main/java/nl/_42/heph/AbstractBuilder.java 77.96% <76.92%> (-1.21%) 17 <10> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1f399...a8904b1. Read the comment docs.

@arjanvlek arjanvlek force-pushed the feature/auto-retrieve-repositories branch 3 times, most recently from 5b62df1 to 6c33224 Compare January 15, 2019 09:37
@arjanvlek arjanvlek changed the title Now automatically retrieves a JpaReository for the given entity class Now automatically retrieves a JpaRepository for the given entity class Jan 15, 2019
@arjanvlek arjanvlek changed the base branch from feature/remove-builderconstructors to feature/code-generation January 17, 2019 16:03
When creating a BuildCommand, it is no longer required to override the
method `getRepository()`. The repository is now looked up using the
`Repositories` class from the Spring Framework.

If no repository is available, the builder still works. You can also
still override the `getRepository()` method in your buildCommand to
return a customized repository instance (or disable the repository on
purpose)

Fixes #6
@arjanvlek arjanvlek force-pushed the feature/auto-retrieve-repositories branch from 6c33224 to a8904b1 Compare January 24, 2019 10:38
@arjanvlek arjanvlek merged commit 5ca0fcf into feature/code-generation Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants