Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade query-string to v8 #70

Open
gidomanders opened this issue Feb 17, 2023 · 1 comment
Open

Upgrade query-string to v8 #70

gidomanders opened this issue Feb 17, 2023 · 1 comment

Comments

@gidomanders
Copy link
Member

There already is a version 8.1 of the query-string library, but since 8.0 the library is a pure ESM package. To be able to use v8+, we have to convert our libraries to become ESM packages as well.
gidomanders pushed a commit that referenced this issue Feb 17, 2023
improvement: upgrade query-string to v8
4be1a3d 
There already is a version 8.1 of the query-string library, but since
8.0 the library is a pure ESM package. To be able to use v8+, we have to
convert our libraries to become ESM packages as well.

Made changes following
https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c to
make this library an ESM package.

Closes #70
@gidomanders
Copy link
Member Author

Tried to convert the library, but the jest-mock-axios library doesn't seem to work with ESM. Need to figure this out later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gidomanders