Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: updated dependencies #615

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

gidomanders
Copy link
Member

No description provided.

@gidomanders gidomanders force-pushed the chores/update-dependencies branch 3 times, most recently from babbf1c to e004021 Compare December 31, 2021 13:32
@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #615 (7e111a4) into master (fbf2fda) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #615   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          131       131           
  Lines         2523      2563   +40     
  Branches       642       680   +38     
=========================================
+ Hits          2523      2563   +40     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/form/utils.ts 100.00% <0.00%> (ø)
src/form/option.ts 100.00% <0.00%> (ø)
src/form/useOptions.ts 100.00% <0.00%> (ø)
src/form/Input/Input.tsx 100.00% <0.00%> (ø)
src/core/Button/Button.tsx 100.00% <0.00%> (ø)
src/form/TextEditor/utils.ts 100.00% <0.00%> (ø)
src/form/ImageUpload/utils.ts 100.00% <0.00%> (ø)
src/form/DateTimeInput/utils.ts 100.00% <0.00%> (ø)
src/core/Button/useShowSpinner.tsx 100.00% <0.00%> (ø)
src/form/DateTimeInput/checkers.ts 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf2fda...7e111a4. Read the comment docs.

Copy link

@TimQuist TimQuist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (with node.js 16 LTS version) and components in storybook seem to work fine. Is there the need to test with other node.js versions?

@gidomanders
Copy link
Member Author

Tested locally (with node.js 16 LTS version) and components in storybook seem to work fine. Is there the need to test with other node.js versions?

No there is no need for testing with other node versions, we have GitHub Actions to check if the build succeeds with those versions. As long as the pipeline succeeds and node v16 works well locally, it's a go.

@gidomanders gidomanders merged commit d271232 into master Jan 7, 2022
@gidomanders gidomanders deleted the chores/update-dependencies branch January 7, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants