Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: select without placeholder #617

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

gidomanders
Copy link
Member

The placeholder you define cannot be disabled. If you don't specify a
placeholder, you still have an empty value you can select even if you
don't want to. It would help if Select would not display an empty option
if the placeholder is empty.

Added check if placeholder is empty to prevent an empty option.

Closes #616

The placeholder you define cannot be disabled. If you don't specify a
placeholder, you still have an empty value you can select even if you
don't want to. It would help if Select would not display an empty option
if the placeholder is empty.

Added check if placeholder is empty to prevent an empty option.

Closes #616
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #617 (30c5fb6) into master (6fe3261) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #617   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          131       131           
  Lines         2521      2523    +2     
  Branches       639       642    +3     
=========================================
+ Hits          2521      2523    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/form/Select/Select.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe3261...30c5fb6. Read the comment docs.

@gidomanders gidomanders merged commit 5501914 into master Jan 5, 2022
@gidomanders gidomanders deleted the improvement/select-no-placeholder branch January 5, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select items placeholder cannot be made disabled
2 participants