Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async stories no query client error #625

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

gidomanders
Copy link
Member

In the storybook, in all AsyncContent, AsyncList and AsyncPage stories,
an error is displayed: No QueryClient set, use QueryClientProvider to
set one.

Added decorator to wrap async stories in QueryClientProvider.

Closes #624

In the storybook, in all AsyncContent, AsyncList and AsyncPage stories,
an error is displayed: No QueryClient set, use QueryClientProvider to
set one.

Added decorator to wrap async stories in QueryClientProvider.

Closes #624
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #625 (4d529e5) into master (4fa8fee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #625   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          133       133           
  Lines         2597      2597           
  Branches       716       716           
=========================================
  Hits          2597      2597           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa8fee...4d529e5. Read the comment docs.

Copy link

@TimQuist TimQuist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works

@gidomanders gidomanders merged commit 9c08b33 into master Jan 25, 2022
@gidomanders gidomanders deleted the fix/async-stories-query-client-error branch January 25, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook Async broken
2 participants