Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image upload buffer not defined #667

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

gidomanders
Copy link
Member

When uploading an image, we get a console error Buffer is not defined.

Added buffer to optional peer dependencies for ImageUpload component.

When uploading an image, we get a console error Buffer is not defined.

Added buffer to optional peer dependencies for ImageUpload component.
@gidomanders gidomanders force-pushed the fix/image-upload-buffer-not-defined branch from 230eaeb to b1ca20e Compare October 21, 2022 09:04
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #667 (b1ca20e) into master (ae27610) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #667   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          131       131           
  Lines         2731      2733    +2     
  Branches       785       785           
=========================================
+ Hits          2731      2733    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/form/ImageUpload/utils.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gidomanders gidomanders merged commit 401f83e into master Oct 21, 2022
@gidomanders gidomanders deleted the fix/image-upload-buffer-not-defined branch October 21, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant