Updated script for POSIX compliance #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- read-call updated to use -r flag. Removed -p flag. - Removed string-indexing in case. - Removed double-bracket syntax. - Removed $() from until-statement. Note that almost all of these changes can be discarded by using #!/bin/bash or similar.
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 2733 2733
Branches 785 785
=========================================
Hits 2733 2733
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gidomanders
approved these changes
Nov 21, 2022
gidomanders
deleted the
673-scriptsdev-publishsh-is-not-posix-compliant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that almost all of these changes can be discarded by using #!/bin/bash or similar.