improvement: add total elements counter to Pagination #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EpicPagination displays the total number of elements. I would like to see that in the Pagination component as well. Added total elements to Pagination component. Changed total elements in EpicPagination to be translatable string. Added possibility to hide total elements in Pagination and EpicPagination. Closes #687
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 2756 2768 +12
Branches 803 815 +12
=========================================
+ Hits 2756 2768 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EpicPagination displays the total number of elements. I would like to see that in the Pagination component as well.
Added total elements to Pagination component.
Changed total elements in EpicPagination to be translatable string. Added possibility to hide total elements in Pagination and EpicPagination.
Closes #687