improvement: form in OpenCloseModal #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the OpenCloseModal for forms, as a submit button is displayed in the footer. There is no possibility however to wrap the modal with a form tag, which causes invalid HTML or could cause unexpected behaviour as the submit button could submit another wrapping form as well. Changed OpenCloseModal to use custom modal with form in content wrapping body and footer. Closes #689
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 131 131
Lines 2768 2772 +4
Branches 815 819 +4
=========================================
+ Hits 2768 2772 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Story voor openCloseModal basic redirect als enigste modal voor mij naar http://localhost:3001/iframe.html? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the OpenCloseModal for forms, as a submit button is displayed in the footer. There is no possibility however to wrap the modal with a form tag, which causes invalid HTML or could cause unexpected behaviour as the submit button could submit another wrapping form as well.
Changed OpenCloseModal to use custom modal with form in content wrapping body and footer.
Closes #689