Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): mapstructure and json tag colocation #85

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

42atomys
Copy link
Owner

@42atomys 42atomys commented Jun 12, 2022

Describe the pull request

mapstructure dont anymore allow us to use json tag field. a tag field colocation is know needed

Checklist

  • I have linked the relative issue to this pull request
  • I have made the modifications or added tests related to my PR
  • I have added/updated the documentation for my RP
  • I put my PR in Ready for Review only when all the checklist is checked

Breaking changes ?
no

Additional context

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2022

Codecov Report

Merging #85 (b82b182) into main (9b6a9d1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files          22       22           
  Lines         968      968           
=======================================
  Hits          910      910           
  Misses         39       39           
  Partials       19       19           
Impacted Files Coverage Δ
pkg/storage/postgres/postgres.go 86.36% <ø> (ø)
pkg/storage/rabbitmq/rabbitmq.go 83.01% <ø> (ø)
pkg/storage/redis/redis.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ecc8c...b82b182. Read the comment docs.

@42atomys 42atomys merged commit 6a62512 into main Jun 12, 2022
@42atomys 42atomys deleted the fix/mapstructure-json-tag branch June 12, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants