Skip to content

Conversation

SergeyKishenin
Copy link
Collaborator

A configuration option for BowerRails was added that invokes rake bower:install and rake bower:resolve tasks before assets precompilation.

Rake::Task['assets:precompile'].enhance ['bower:install', 'bower:resolve'] feature should be optional as it can break deploy process sometimes. Or it can be done manually.

So I find this solution the most optimal and it can be merged if you agree. @rharriso, @jimpo, @romanenko

It invokes rake bower:install and rake bower:resolve tasks before assets precompilation
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 588b4ec on SergeyKishenin:resolve_before_precompile-option into 6197ca1 on 42dev:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+10.33%) when pulling 588b4ec on SergeyKishenin:resolve_before_precompile-option into 6197ca1 on 42dev:master.

@romanenko
Copy link
Contributor

I agree, that reinstallation must be optional: it can take a long time to complete. Another reason is that some people keep folder with bower assets in .gitignore, so it is a must for them to reinstall assets on every deploy.

+1 for merge.

rharriso added a commit that referenced this pull request Jan 8, 2014
@rharriso rharriso merged commit 05cbc00 into rharriso:master Jan 8, 2014
@SergeyKishenin SergeyKishenin deleted the resolve_before_precompile-option branch January 8, 2014 05:37
@kenips
Copy link
Contributor

kenips commented Jan 16, 2014

Hey @SergeyKishenin I'm on 0.6.1 and I put the BowerRails.configure... block in config/initializer/bower_rails.rb inside my app. It says no method configure for BowerRails module. Seeing that you have class << self I don't see you've done anything wrong, so you know what's causing the class not to be defined? Or am I supposed to put the block somewhere else?

@SergeyKishenin
Copy link
Collaborator Author

Hey, @kenips. This feature is not released yet. Try the edge version gem 'bower-rails', github: '42dev/bower-rails

@kenips
Copy link
Contributor

kenips commented Jan 16, 2014

Oh! What am I doing here..... thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants