Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutting down connection pool info messages #371

Closed
tovbinm opened this issue Mar 13, 2020 · 1 comment
Closed

Shutting down connection pool info messages #371

tovbinm opened this issue Mar 13, 2020 · 1 comment

Comments

@tovbinm
Copy link

tovbinm commented Mar 13, 2020

When using the client the following INFO messages are printed for each API invocation:

o.h.c.PoolManager - Shutting down connection pool: curAllocated=1 idleQueues.size=1 waitQueue.size=0 maxWaitQueueLimit=256 closed=false

Is this by design? Why shutdown connection pool on each API call?
@BenFradet
Copy link
Contributor

This is because the http client we use to make the call is short-lived.
However, I agree we definitely could support two modes of executions:

  • the current one with a short-lived client
  • a new one which defers the client management to the library user through dependency injection

BenFradet added a commit that referenced this issue Mar 16, 2020
@BenFradet
Require an http4s client to provide more flexibility, fixes #371
5ef6dbd
BenFradet added a commit that referenced this issue Mar 17, 2020
@BenFradet
Require an http4s client to provide more flexibility, fixes #371
e77758a
BenFradet added a commit that referenced this issue Mar 17, 2020
@BenFradet
Require an http4s client to provide more flexibility, fixes #371
ea964fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tovbinm @BenFradet