Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hood plugin to benchmark comparison #38

Merged
merged 20 commits into from
Feb 25, 2019
Merged

Conversation

AdrianRaFo
Copy link
Contributor

@AdrianRaFo AdrianRaFo commented Feb 6, 2019

Add Hood plugin https://github.com/47deg/hood to compare benchmarks to compare benchmarks for each PR and keep updated master benchmarks.
Also fix bintray settings.
Related to #42
Fixes #25

@AdrianRaFo AdrianRaFo changed the title Test pr Add hood plugin to benchmark comparison Feb 17, 2019
@AdrianRaFo AdrianRaFo changed the title Add hood plugin to benchmark comparison WIP Add hood plugin to benchmark comparison Feb 17, 2019
@AdrianRaFo AdrianRaFo changed the title WIP Add hood plugin to benchmark comparison Add hood plugin to benchmark comparison Feb 19, 2019
@47degdev
Copy link
Contributor

47degdev commented Feb 19, 2019

Hood benchmark comparison:
✔️ Decoding

Benchmark Value
master_benchmark 11709.599148
helios_benchmark 11783.219344

⚠️ Parsing

Benchmark Value
master_benchmark 22403.085175
helios_benchmark 21982.827831

Copy link
Contributor

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I mentioned to @AdrianRaFo on Slack it might be better to have a second review of someone good with build automation or gradle.

.travis.yml Outdated Show resolved Hide resolved
helios-benchmarks/build.gradle Show resolved Hide resolved
helios-benchmarks/build.gradle Outdated Show resolved Hide resolved
helios-benchmarks/build.gradle Outdated Show resolved Hide resolved
@AdrianRaFo AdrianRaFo merged commit 675552c into master Feb 25, 2019
@AdrianRaFo AdrianRaFo deleted the arf-add-benchmark-plugin branch February 25, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adds performance check to ci
5 participants