Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient parsing of UUIDs from strings #192

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

plokhotnyuk
Copy link
Contributor

@plokhotnyuk plokhotnyuk commented Jun 6, 2020

Before

Corretto 8

[info] Benchmark                  Mode  Cnt       Score      Error  Units
[info] UUIDBenchmark.fromString  thrpt   15  948839.022 ± 7011.880  ops/s

Corretto 11

[info] Benchmark                  Mode  Cnt        Score       Error  Units
[info] UUIDBenchmark.fromString  thrpt   15  1500465.570 ± 11592.723  ops/s

OpenJDK 15

[info] Benchmark                  Mode  Cnt        Score       Error  Units
[info] UUIDBenchmark.fromString  thrpt   15  1826314.320 ± 33815.069  ops/s

After

Corretto 8

[info] Benchmark                  Mode  Cnt         Score       Error  Units
[info] UUIDBenchmark.fromString  thrpt   15  21568831.647 ± 83625.539  ops/s

Corretto 11

[info] Benchmark                  Mode  Cnt         Score       Error  Units
[info] UUIDBenchmark.fromString  thrpt   15  23971815.448 ± 35417.588  ops/s

OpenJDK 15

[info] Benchmark                  Mode  Cnt         Score       Error  Units
[info] UUIDBenchmark.fromString  thrpt   15  27989191.275 ± 37117.812  ops/s

@plokhotnyuk plokhotnyuk requested a review from gutiory as a code owner June 6, 2020 14:58
@codecov
Copy link

codecov bot commented Jun 6, 2020

Codecov Report

Merging #192 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          11       11           
  Lines          78       78           
  Branches        1        1           
=======================================
  Hits           77       77           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcfe2f8...7956ad6. Read the comment docs.

@plokhotnyuk plokhotnyuk force-pushed the master branch 6 times, most recently from a4b4fb6 to 7be56f3 Compare June 6, 2020 16:10
Copy link
Collaborator

@alejandrohdezma alejandrohdezma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this @plokhotnyuk! It looks awesome!

@alejandrohdezma alejandrohdezma merged commit 2df0210 into 47degrees:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants