Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Routing misses searchParams on mount #417

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Conversation

franky47
Copy link
Member

@franky47 franky47 commented Nov 30, 2023

When init'ing a hook, it sometimes fails to pick up the correct value for the search params. Adding an end-to-end test for the routing tour which should cover all possible cases.

  • Fix basePath test
  • Investigate why 14.0.3 no longer calls the wrapped history methods: fixed in next@14.0.4-canary.37 by Ensure original history is read in effect vercel/next.js#58861
  • Add docs specifying that 14.0.3 should use the windowHistorySupport flag, and 14.0.4 no longer needs it
  • Merge this PR once 14.0.4 is published (so latest tests pass on CI).

Closes #416.

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-usequerystate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 10:57pm

@franky47
Copy link
Member Author

franky47 commented Dec 2, 2023

Tests included here pass under vercel/next.js#58861.

@franky47 franky47 merged commit a7bf0cd into next Dec 7, 2023
13 checks passed
@franky47 franky47 deleted the fix/routing-tour branch December 7, 2023 23:02
Copy link

github-actions bot commented Dec 8, 2023

🎉 This PR is included in version 1.13.1-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Dec 8, 2023

🎉 This PR is included in version 1.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL query params are not detected when navigating with the Next Link component
1 participant