Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add controling of zoom factor of search ROI in main GUI #540

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Feb 18, 2022

This is the same as #538 but for PartSeg main GUI.

…rcery refactored) (#541)

Co-authored-by: Sourcery AI <>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/540

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #540 (c34c709) into develop (b81fb09) will increase coverage by 0.03%.
The diff coverage is 93.10%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #540      +/-   ##
===========================================
+ Coverage    77.01%   77.05%   +0.03%     
===========================================
  Files          144      144              
  Lines        18597    18606       +9     
===========================================
+ Hits         14323    14337      +14     
+ Misses        4274     4269       -5     
Impacted Files Coverage Δ
package/PartSeg/common_gui/universal_gui_part.py 56.79% <0.00%> (+0.46%) ⬆️
package/PartSeg/common_gui/advanced_tabs.py 84.71% <100.00%> (+3.33%) ⬆️
package/PartSeg/common_gui/custom_buttons.py 100.00% <100.00%> (ø)
package/PartSeg/common_gui/napari_image_view.py 84.92% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81fb09...c34c709. Read the comment docs.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 18, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.42%.

Quality metrics Before After Change
Complexity 3.09 ⭐ 2.87 ⭐ -0.22 👍
Method Length 58.48 ⭐ 58.51 ⭐ 0.03 👎
Working memory 7.67 🙂 7.59 🙂 -0.08 👍
Quality 71.65% 🙂 72.07% 🙂 0.42% 👍
Other metrics Before After Change
Lines 1921 1990 69
Changed files Quality Before Quality After Quality Change
package/PartSeg/common_gui/advanced_tabs.py 76.78% ⭐ 75.93% ⭐ -0.85% 👎
package/PartSeg/common_gui/custom_buttons.py 93.21% ⭐ 92.84% ⭐ -0.37% 👎
package/PartSeg/common_gui/napari_image_view.py 67.43% 🙂 67.62% 🙂 0.19% 👍
package/PartSeg/common_gui/universal_gui_part.py 75.91% ⭐ 75.68% ⭐ -0.23% 👎
package/tests/test_PartSeg/test_common_gui.py 74.28% 🙂 75.29% ⭐ 1.01% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSeg/common_gui/napari_image_view.py ImageView.component_mark 14 🙂 223 ⛔ 11 😞 41.69% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView.__init__ 1 ⭐ 519.96 ⛔ 14 😞 42.52% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView.print_info 19 😞 150.97 😞 11 😞 43.74% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py ImageView._mark_layer 8 ⭐ 186 😞 13 😞 46.47% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/universal_gui_part.py Spacing.__init__ 4 ⭐ 213.98 ⛔ 14 😞 46.81% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/540

@Czaki Czaki changed the title feat: Add conroling of zoom factor of search feature in main gui feat: Add controling of zoom factor of search feature in main gui Feb 18, 2022
@Czaki Czaki changed the title feat: Add controling of zoom factor of search feature in main gui feat: Add controling of zoom factor of search ROI in main GUI Feb 18, 2022
@Czaki Czaki merged commit 099b03f into develop Feb 18, 2022
@Czaki Czaki deleted the feature/zoom_factor_main_gui branch February 18, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant