Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Switch serialization backen to nme #569

Merged
merged 5 commits into from
Apr 3, 2022
Merged

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Apr 3, 2022

Because PartSegCore.class_register and most of PartSegCore.json_hooks was extracted to nme package. To do not duplicate code replace inner import with import from nme.

@Czaki Czaki added this to the 0.14.0 milestone Apr 3, 2022
@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/569

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/569

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/569

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/569

1 similar comment
@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/569

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #569 (0076f31) into develop (97e32b2) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #569      +/-   ##
===========================================
- Coverage    77.78%   77.65%   -0.13%     
===========================================
  Files          143      142       -1     
  Lines        19163    18989     -174     
===========================================
- Hits         14906    14746     -160     
+ Misses        4257     4243      -14     
Impacted Files Coverage Δ
package/PartSeg/common_gui/napari_image_view.py 84.78% <100.00%> (ø)
package/PartSegCore/algorithm_describe_base.py 87.34% <100.00%> (ø)
package/PartSegCore/analysis/calculation_plan.py 62.96% <100.00%> (ø)
package/PartSegCore/analysis/measurement_base.py 88.77% <100.00%> (ø)
...ge/PartSegCore/analysis/measurement_calculation.py 97.09% <100.00%> (ø)
package/PartSegCore/image_operations.py 87.93% <100.00%> (ø)
package/PartSegCore/json_hooks.py 100.00% <100.00%> (+11.11%) ⬆️
package/PartSegCore/mask_create.py 95.55% <100.00%> (ø)
package/PartSegCore/segmentation/algorithm_base.py 91.24% <100.00%> (ø)
...ackage/PartSegCore/segmentation/noise_filtering.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97e32b2...0076f31. Read the comment docs.

@Czaki Czaki changed the title Switch serialization backen to nme refactor: Switch serialization backen to nme Apr 3, 2022
@Czaki Czaki merged commit 908d9ba into develop Apr 3, 2022
@Czaki Czaki deleted the bugfix/swith_to_nme branch April 3, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant