Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delay setting image if an algorithm is still running #627

Merged
merged 3 commits into from
May 11, 2022

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented May 11, 2022

This PR solves the bug of setting a new image to already running ROI Extraction algorithm.

fix PARTSEG-K3

@Czaki Czaki added the bugfix label May 11, 2022
@Czaki Czaki added this to the v0.14.3 milestone May 11, 2022
@Czaki Czaki changed the title Delay setting image if algorithm is still running fix: Delay setting image if an algorithm is still running May 11, 2022
@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented May 11, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/627
Updated at: 05/11/2022 , 11:37:26

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #627 (fb9eab3) into develop (9caf476) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #627      +/-   ##
===========================================
+ Coverage    81.52%   81.54%   +0.01%     
===========================================
  Files          143      143              
  Lines        19120    19140      +20     
===========================================
+ Hits         15588    15608      +20     
  Misses        3532     3532              
Impacted Files Coverage Δ
...kage/PartSeg/common_backend/segmentation_thread.py 100.00% <100.00%> (ø)
...ckage/PartSeg/common_gui/algorithms_description.py 80.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9caf476...fb9eab3. Read the comment docs.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 11, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.07%.

Quality metrics Before After Change
Complexity 2.23 ⭐ 2.22 ⭐ -0.01 👍
Method Length 48.27 ⭐ 48.57 ⭐ 0.30 👎
Working memory 5.86 ⭐ 5.84 ⭐ -0.02 👍
Quality 78.06% 78.13% 0.07% 👍
Other metrics Before After Change
Lines 1465 1517 52
Changed files Quality Before Quality After Quality Change
package/PartSeg/common_backend/segmentation_thread.py 84.64% ⭐ 83.75% ⭐ -0.89% 👎
package/PartSeg/common_gui/algorithms_description.py 78.22% ⭐ 78.22% ⭐ 0.00%
package/tests/test_PartSeg/test_common_backend.py 77.22% ⭐ 77.28% ⭐ 0.06% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSeg/common_gui/algorithms_description.py FormWidget._add_to_layout 12 🙂 199 😞 10 😞 46.98% 😞 Try splitting into smaller methods. Extract out complex expressions
package/tests/test_PartSeg/test_common_backend.py TestBaseSettings.test_base_settings_history 0 ⭐ 253 ⛔ 10 😞 55.13% 🙂 Try splitting into smaller methods. Extract out complex expressions
package/tests/test_PartSeg/test_common_backend.py TestExceptHook.test_my_excepthook 0 ⭐ 266 ⛔ 9 🙂 56.58% 🙂 Try splitting into smaller methods
package/tests/test_PartSeg/test_common_backend.py TestBaseSettings.test_image_settings 0 ⭐ 246 ⛔ 9 🙂 57.54% 🙂 Try splitting into smaller methods
package/PartSeg/common_gui/algorithms_description.py QtAlgorithmProperty._get_field_from_value_type 10 🙂 147 😞 6 ⭐ 62.61% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Czaki Czaki merged commit fdc5e37 into develop May 11, 2022
@Czaki Czaki deleted the bugfix/load_image_when_running_algoritm branch May 11, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant