Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix reporting error in load settings from drive #725

Merged
merged 17 commits into from
Oct 14, 2022

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Sep 28, 2022

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 28, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.16%.

Quality metrics Before After Change
Complexity 1.53 ⭐ 1.52 ⭐ -0.01 👍
Method Length 68.38 🙂 68.29 🙂 -0.09 👍
Working memory 5.58 ⭐ 5.56 ⭐ -0.02 👍
Quality 75.33% 75.49% 0.16% 👍
Other metrics Before After Change
Lines 5075 5143 68
Changed files Quality Before Quality After Quality Change
package/PartSeg/_launcher/check_version.py 65.58% 🙂 65.06% 🙂 -0.52% 👎
package/PartSeg/common_backend/base_settings.py 82.95% ⭐ 83.51% ⭐ 0.56% 👍
package/PartSeg/common_gui/error_report.py 51.47% 🙂 51.57% 🙂 0.10% 👍
package/PartSeg/common_gui/main_window.py 71.96% 🙂 71.97% 🙂 0.01% 👍
package/PartSegCore/io_utils.py 83.35% ⭐ 83.15% ⭐ -0.20% 👎
package/PartSegCore/utils.py 80.28% ⭐ 80.50% ⭐ 0.22% 👍
package/tests/test_PartSeg/test_common_backend.py 73.11% 🙂 73.44% 🙂 0.33% 👍
package/tests/test_PartSeg/test_common_gui.py 75.40% ⭐ 75.40% ⭐ 0.00%
package/tests/test_PartSegCore/test_io.py 71.79% 🙂 71.85% 🙂 0.06% 👍
package/tests/test_PartSegCore/test_json_hooks.py 89.24% ⭐ 86.75% ⭐ -2.49% 👎
package/tests/test_PartSegCore/test_utils.py 80.37% ⭐ 80.39% ⭐ 0.02% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
package/PartSeg/common_gui/error_report.py ErrorDialog.__init__ 6 ⭐ 418 ⛔ 13 😞 39.70% 😞 Try splitting into smaller methods. Extract out complex expressions
package/tests/test_PartSegCore/test_io.py TestSaveHistory.perform_roi_info_history_test 2 ⭐ 378 ⛔ 14 😞 42.76% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/error_report.py ErrorDialog.send_information 11 🙂 260 ⛔ 10 😞 44.17% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/main_window.py BaseMainWindow.__init__ 10 🙂 280 ⛔ 10 😞 44.22% 😞 Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/error_report.py DataImportErrorDialog.__init__ 15 🙂 306 ⛔ 7 🙂 45.57% 😞 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Sep 28, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/725
Updated: 2022-10-13T22:56:15.272160

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 88.58% // Head: 88.63% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (634071a) compared to base (fd6e600).
Patch coverage: 97.22% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #725      +/-   ##
===========================================
+ Coverage    88.58%   88.63%   +0.05%     
===========================================
  Files          190      190              
  Lines        29347    29386      +39     
===========================================
+ Hits         25997    26047      +50     
+ Misses        3350     3339      -11     
Impacted Files Coverage Δ
package/PartSeg/common_gui/main_window.py 86.80% <ø> (ø)
package/PartSegCore/io_utils.py 89.51% <85.71%> (+1.92%) ⬆️
package/PartSeg/common_backend/base_settings.py 96.55% <94.44%> (+1.15%) ⬆️
package/PartSeg/_launcher/check_version.py 100.00% <100.00%> (ø)
package/PartSeg/common_gui/error_report.py 73.48% <100.00%> (+0.44%) ⬆️
package/PartSegCore/utils.py 93.88% <100.00%> (ø)
package/tests/test_PartSeg/test_common_backend.py 100.00% <100.00%> (ø)
package/tests/test_PartSeg/test_common_gui.py 99.83% <100.00%> (+<0.01%) ⬆️
package/tests/test_PartSegCore/test_io.py 100.00% <100.00%> (ø)
package/tests/test_PartSegCore/test_json_hooks.py 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Czaki Czaki changed the title bugfix: Fix reportin error in load settings from drive bugfix: Fix reporting error in load settings from drive Sep 30, 2022
@Czaki Czaki added this to the v0.14.4 milestone Oct 13, 2022
@Czaki Czaki merged commit ef43db3 into develop Oct 14, 2022
@Czaki Czaki deleted the bughfix/error_report_on_import branch October 14, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant