Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix minimal requirments pipeline #877

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Jan 4, 2023

No description provided.

@Czaki Czaki added this to the 0.15.0 milestone Jan 4, 2023
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 4, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 8.58%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 95.00 🙂 145.00 😞 50.00 👎
Working memory 7.00 🙂 8.00 🙂 1.00 👎
Quality 76.31% 67.73% 🙂 -8.58% 👎
Other metrics Before After Change
Lines 13 27 14
Changed files Quality Before Quality After Quality Change
build_utils/create_minimal_req.py 76.31% ⭐ 67.73% 🙂 -8.58% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Jan 4, 2023

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/877
Updated: 2023-01-04T15:29:16.117677

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Czaki Czaki merged commit 736379c into develop Jan 4, 2023
@Czaki Czaki deleted the bugfix/fix_minimal_req branch January 4, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant