Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use text icon, not pixmap icon in colormap and labels list #938

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Apr 18, 2023

No description provided.

@Czaki Czaki added this to the 0.15.0 milestone Apr 18, 2023
@Czaki Czaki changed the title Use text icon, not pixmap icon in colormap and labels list bugfix: Use text icon, not pixmap icon in colormap and labels list Apr 18, 2023
@Czaki Czaki changed the title bugfix: Use text icon, not pixmap icon in colormap and labels list fix: Use text icon, not pixmap icon in colormap and labels list Apr 18, 2023
@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Apr 18, 2023

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/938
Updated: 2023-04-18T22:05:42.923998

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (44ce9df) 91.49% compared to head (357ac05) 91.52%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #938      +/-   ##
===========================================
+ Coverage    91.49%   91.52%   +0.02%     
===========================================
  Files          198      198              
  Lines        30678    30691      +13     
===========================================
+ Hits         28070    28090      +20     
+ Misses        2608     2601       -7     
Impacted Files Coverage Δ
package/PartSeg/common_gui/colormap_creator.py 85.77% <100.00%> (ø)
package/PartSeg/common_gui/label_create.py 87.64% <100.00%> (+0.82%) ⬆️
package/tests/test_PartSeg/test_label_choose.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Czaki Czaki merged commit b2ccddd into develop Apr 19, 2023
@Czaki Czaki deleted the bugfix/better_icons branch April 19, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant