Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New keys in dictionary #34

Merged
merged 2 commits into from
Oct 23, 2018
Merged

New keys in dictionary #34

merged 2 commits into from
Oct 23, 2018

Conversation

zhovner
Copy link
Contributor

@zhovner zhovner commented Oct 21, 2018

Nice to have strong dictionary right out of the box

@4ZM
Copy link
Owner

4ZM commented Oct 22, 2018

Nice! Please format as lower case to avoid unnecessary diffs with existing directory. Also please use full address instead of urlshortners (to not make people nervous about clicking links).

@@ -1,30 +1,86 @@
# This sample dictionary for mfterm contains publicly available
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point in changing this comment?

Copy link
Contributor Author

@zhovner zhovner Oct 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was fully replace your dictionary with my modified dictionary from MifareClassicTool project. I think it's easier to keep updated only one version of dictionary.

dictionary.txt Outdated
FC0001877BF7

# Keys from:
# http://bit.ly/1bdSbJl
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expand this urlshortener

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Also expands the URL shortener.
@4ZM 4ZM merged commit 130bc38 into 4ZM:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants