Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/generator/makePublicFolder.js should first check if source folders exists, shouldn't log to the console and should wrap all operations in a single try/catch block. #132

Closed
jeffschwartz opened this issue May 5, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request generator related Issue is generator related
Milestone

Comments

@jeffschwartz
Copy link
Contributor

  1. Remove try/catch block from each operation and replace with a single try/catch block wrapping all operations.
  2. Remove console.log messages written when source folders don't exist.
  3. Check if source folders exist before copying files.
@jeffschwartz jeffschwartz added enhancement New feature or request generator related Issue is generator related labels May 5, 2021
@jeffschwartz jeffschwartz added this to the v6.0.2 milestone May 5, 2021
@jeffschwartz jeffschwartz self-assigned this May 5, 2021
@jeffschwartz jeffschwartz added bug Something isn't working and removed bug Something isn't working labels May 5, 2021
jeffschwartz added a commit that referenced this issue May 5, 2021
exist, don't log messages to the console, and wrap
all operations in a single try/catch block
@jeffschwartz jeffschwartz changed the title lib/generator/makePublicFolder.js should first check if source folders exists before copying files to destination folders. lib/generator/makePublicFolder.js should first check if source folders exists, shouldn't log to the console and should wrap all operations in a single try/catch block. May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request generator related Issue is generator related
Projects
None yet
Development

No branches or pull requests

1 participant