Lookup sort #86
Merged
Lookup sort #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e after Biosource
…lds, edited test_order_sorter in test_import_data
… for --type all to get_field_info.main()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented ordering of fields by lookup number, and automatic ordering of sheets. Removed "--order" arg. Removed old ordering functions and tests. Also modified sheet_order to move Biosample and BiosampleCellCulture after Biosource because it seemed to make more sense.
I also removed "ExperimentMic_Path" from sheet_order because it prevents '--type all' from working, but I can add it back later when a sheet can be generated from it.
If it's better to keep old tests and functions and just comment them out, I can revert to a previous commit.