-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved IntegratedFixture and static check cleanups (C4-932) #222
Conversation
…ed version of the GitPython library.
…A will do. Update qa_checkers to do type declarations on WARNING_CATEGORY in two classes.
Pull Request Test Coverage Report for Build 3161551459
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small clarifying question
warnings.warn(message, category=warning_category, stacklevel=2) | ||
else: # if_used == 'error' | ||
raise AssertionError(message) | ||
raise AssertionError(message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the if_used
behavior here removed intentionally? If so docstring should be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's intentional. It was recently added and no one is using it yet. I found a place higher in the call chain to do this effect more simply. I'll adjust doc string.
qa_checkers.confirm_no_uses
to remove theif_used
argument in favor of a simpler implementation. Since this is testing-only, not something used in production, and since there are believed to be no uses outside the repo, no major version bump.IntegratedFixture
happen at instance instantiation time. That simplifies the loading actions needed. Those can happen inconftest.py
rather than inff_mocks
, which should allowdcicutils.ff_mocks
to be imported more easily (C4-932).