Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL not supported #20

Closed
littlesandra88 opened this issue Apr 20, 2014 · 4 comments
Closed

URL not supported #20

littlesandra88 opened this issue Apr 20, 2014 · 4 comments

Comments

@littlesandra88
Copy link

This URL is not supported.
https://fallinloveyoulose.imgur.com/all
@4pr0n 4pr0n closed this as completed in 0916252 Apr 20, 2014
@4pr0n
Copy link
Owner

4pr0n commented Apr 20, 2014

Details in commit. Upgrade from wtihin the app or download the latest version.

@littlesandra88
Copy link
Author

Even with 1.0.21 do I get "Could not find ripper for given URL". Have tried with and without https: and /all. Same result

@4pr0n 4pr0n reopened this Apr 20, 2014
4pr0n added a commit that referenced this issue Apr 21, 2014
@4pr0n
1.0.22 - Fixing bug where nothing worked #20
d5822b3 
Adding the /rippers/video subdirectory package caused the
auto-class-finder to try to initialize a class that did not exist (dir
name instead of class name).
@4pr0n
Copy link
Owner

4pr0n commented Apr 21, 2014

Ok. That was a big bug. Glad someone told me (thanks to you and @CaspianRoach in #21).

This is what I get for testing in Eclipse but not from the .jar file itself.

Looks like this was introduced in 9946777 when the rippers/video subdirectory was added. There's a function that iterates over all rippers in the rippers directory and a new subdirectory caused unexpected behavior.

@4pr0n 4pr0n mentioned this issue Apr 21, 2014
Closed
@4pr0n
Copy link
Owner

4pr0n commented Apr 21, 2014

Confirmed fixed in #21. Be sure to update to 1.0.22 or above for a working version.

@4pr0n 4pr0n closed this as completed Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@littlesandra88 @4pr0n