Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.9.0 alpha #404

Merged
merged 18 commits into from
Nov 11, 2020
Merged

2.9.0 alpha #404

merged 18 commits into from
Nov 11, 2020

Conversation

ulmentflam
Copy link
Contributor

Description

Pulley 2.9.0 has new properties to support a new displayMode. The base functionality should work without any significant changes. The biggest change being the new displayMode of .compact to replicate Apple Maps Behavior on the iPhone SE size class devices. This is an exact replica of the behavior of the Apple Maps drawer, therefor when the currentDisplayMode of the PulleyViewController is .compact then the only supportedDrawerPositions for the view controller when in .compact mode are .open, .closed, and .collapsed. This mode also has new @IBInspectable properties, compactInsets and compactWidth. This mode behaves in a very similar way to .panel mode. See the pull request here for the motivation behind this feature. Also in this release, setDrawerContentViewController(controller: UIViewController, position: PulleyPosition? = nil, animated: Bool = true, completion: PulleyAnimationCompletionBlock?) has a new optional parameter position to set a new drawer position the drawer when a new DrawerContentViewController is set. See this pull request for the motivation behind this feature.

Fixes # (issue)
#347
#349

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you performed to verify your changes. Provide instructions so we can reproduce. Please provide details on how you tested supported versions of iOS and Xcode. Please make sure you have tested on all device size classes and orientations. Please also list any relevant details for your test configuration

  • Test iOS 14
  • Test iOS 13
  • Test iOS 12
  • Test iOS 11
  • Test iOS 10
  • Test iOS 9

Test Configuration

  • Xcode Versions: 12.1
  • Simulators: iPad Pro (14.x), iPhone SE (12.x)
  • Physical Hardware: iPhone 11 (14.2)

Checklist:

  • My code follows the style guidelines of this project
  • My code does not break backwards compatibility with earlier versions of PulleyLib
  • My code is fully functional with all supported device sizes and orientations
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked that my code does not break the behavior of the Sample/Demo app
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested and can prove my fix is effective or that my feature works

@ulmentflam ulmentflam merged commit 5d5ec9c into master Nov 11, 2020
@ulmentflam ulmentflam deleted the 2.9.0-alpha branch November 11, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants