-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.9.0 alpha #404
Merged
Merged
2.9.0 alpha #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't default to collapsed state when current drawer position isn't supported
Designate new drawer position on transition
…ability and create an example
…f the compact position for Apple Maps
…kwards compatability issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pulley 2.9.0 has new properties to support a new displayMode. The base functionality should work without any significant changes. The biggest change being the new displayMode of
.compact
to replicate Apple Maps Behavior on the iPhone SE size class devices. This is an exact replica of the behavior of the Apple Maps drawer, therefor when thecurrentDisplayMode
of thePulleyViewController
is.compact
then the onlysupportedDrawerPositions
for the view controller when in.compact
mode are.open
,.closed
, and.collapsed
. This mode also has new @IBInspectable properties,compactInsets
andcompactWidth
. This mode behaves in a very similar way to.panel
mode. See the pull request here for the motivation behind this feature. Also in this release,setDrawerContentViewController(controller: UIViewController, position: PulleyPosition? = nil, animated: Bool = true, completion: PulleyAnimationCompletionBlock?)
has a new optional parameterposition
to set a new drawer position the drawer when a newDrawerContentViewController
is set. See this pull request for the motivation behind this feature.Fixes # (issue)
#347
#349
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you performed to verify your changes. Provide instructions so we can reproduce. Please provide details on how you tested supported versions of iOS and Xcode. Please make sure you have tested on all device size classes and orientations. Please also list any relevant details for your test configuration
Test Configuration
Checklist: