Add support for distribution metric type #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
requested changes
Mar 16, 2021
cadence/src/client.rs
Outdated
| /// `MetricBuilder` that can be used to add tags to the metric. | ||
| fn distribution_with_tags<'a>(&'a self, key: &'a str, value: u64) -> MetricBuilder<'_, '_, Distribution>; | ||
|
|
||
| /// Record a single distribution value with the given key. |
There was a problem hiding this comment.
If you don't have a specific usecase for treating these as times, would you mind removing the duration methods? They were added to Histograms (in Cadence) after the fact by request. I'd rather not add extra methods unless people specifically need them.
|
@56quarters, if it's not too much trouble, would you be able to cut a release containing the distribution stuff? :) |
|
Sure, I'll try to do that in the next few days.
…On Thu, Mar 18, 2021, 13:48 Duarte Nunes ***@***.***> wrote:
@56quarters <https://github.com/56quarters>, if it's not too much
trouble, would you be able to cut a release containing the distribution
stuff? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#125 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAITHTLGMW2TRIXCSDSCLFTTEI4ILANCNFSM4ZI3IM5A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Datadog-specific distribution metric type, documented here.