Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new time_duration method to Timed trait #55

Merged
merged 1 commit into from
Jan 29, 2017
Merged

Conversation

56quarters
Copy link
Owner

@56quarters 56quarters commented Jan 27, 2017

Add a new method for recording timings using std::time::Duration
instead of a u64 of milliseconds. The duration is converted to the
number of milliseconds before being sent to the sink. Any integer
overflow will cause an error to be returned.

Fixes #48

Add a new method for recording timings using std::time::Duration
instead of a u64 of milliseconds. The duration is converted to the
number of milliseconds before being sent to the sink. Any integer
overflow will cause an error to be returned.

Fixes #48
Copy link
Contributor

@robinst robinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@56quarters
Copy link
Owner Author

Thanks!

@56quarters 56quarters merged commit 488cde3 into master Jan 29, 2017
@56quarters 56quarters deleted the time_duration branch January 29, 2017 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants