Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(enhancement): Added relative dependencies for Netpol-Adapter #87

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

VedRatan
Copy link
Collaborator

Description

This PR introduces the relative dependencies that will make the netpol-adapter module to use the relative dependency of the parent directory instead of absolute github dependency.

Fixes # (issue)

Does this PR introduce a breaking change?

Checklist

  • PR title follows the <type>: <description> convention
  • I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

@anurag-rajawat
Copy link
Collaborator

Please resolve conflicts, rebase and squash commits, and then we're good to merge this.

@VedRatan
Copy link
Collaborator Author

@anurag-rajawat ig we're good to merge this one

Copy link
Collaborator

@anurag-rajawat anurag-rajawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your git commits and address one minor comment.

pkg/adapter/nimbus-netpol/go.mod Show resolved Hide resolved
@VedRatan VedRatan force-pushed the netpol_dependency branch 2 times, most recently from a4176fd to b6df2f6 Compare March 21, 2024 12:35
Signed-off-by: Ved Ratan <vedratan8@gmail.com>

added relative dependencies

Signed-off-by: Ved Ratan <vedratan8@gmail.com>

kyverno

Signed-off-by: Ved Ratan <vedratan8@gmail.com>

updated adapter for namespaced policy

Signed-off-by: Ved Ratan <vedratan8@gmail.com>

added clusterpolicy logic

Signed-off-by: Ved Ratan <vedratan8@gmail.com>

minor fixes

Signed-off-by: Ved Ratan <vedratan8@gmail.com>

fix(deps): Update go version to 1.22 from 1.21

Signed-off-by: Anurag Rajawat <anurag@accuknox.com>
@VedRatan
Copy link
Collaborator Author

can we merge this? @anurag-rajawat

@anurag-rajawat anurag-rajawat merged commit 4c38a71 into 5GSEC:main Mar 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants