This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
update readme #18
Merged
update readme #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandomg
suggested changes
Jun 11, 2020
README.md
Outdated
| ``` | ||
|
|
||
| And then include it wrapping your application. |
There was a problem hiding this comment.
Not sure about the wrapping as it's not wrapping it, but at the same App level.
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Agupane
approved these changes
Jun 12, 2020
|
Can we add what version of material-ui is required ... looking in the package.json is annoying :P |
|
styled-components is also a peer dependency, right? |
rmeissner
reviewed
Jun 17, 2020
README.md
Outdated
| This library makes use of [material-ui](https://material-ui.com/) as a `peerDependency`, this means you must install it in your Safe App. Make sure to provide the same version as the one being used by the current version of this library. | ||
|
|
||
| Once everything is installed, you have to instantiate a [ThemeProvider](https://styled-components.com/docs/api#themeprovider) from [styled-components](https://@gnosis.pm/safe-react-components/). |
There was a problem hiding this comment.
why does styled-components link to https://@gnosis.pm/safe-react-components/
mmv08
suggested changes
Jun 18, 2020
|
|
||
| ```bash | ||
| yarn add @gnosis.pm/safe-react-components |
There was a problem hiding this comment.
we should also include npm command
| src: local('Averta'), local('Averta Bold'), | ||
| url(${avertaFont}) format('woff2'), | ||
| url(${avertaBoldFont}) format('woff'); |
There was a problem hiding this comment.
Please include font-display swap in this example
https://developers.google.com/web/updates/2016/02/font-display
|
Changes pushed! thx for the review! |
|
Travis automatic deployment: |
rmeissner
approved these changes
Jun 18, 2020
lukasschor
approved these changes
Jun 19, 2020
mmv08
approved these changes
Jun 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.