Settings Improvements

[lukasschor]

No existing owner as new owner

Not allow to replace with address which is already an owner (currently its possible but the tx eventually fails and owner gets reset to previous one).

Owners: Change text

Text "Add, remove and replace owners or rename existing owners. Owner names are only stored locally and never shared with Gnosis or any third parties."

Confirm name change

Confirmation message (non-sticky notification) after changing Safe name: "Safe name changed"

Owners: Remove pagination

Remove pagination and change text to : "Any transaction requires the confirmation of:"

Threshold: Change text

Threshold: Remove line break in text

Threshold in read-only mode

Show threshold tab also in read-only mode

Consistent height of settings options

Height of white backgrounds is different for the different sections (safe name, owner, threshold)

[germartinez]

@lukasschor

Show State

I assume we do this with notifications #135

Confirm name change

There are no designs for this. Is it a different page or just a notification in the bottom right corner?
What would be the exact text to show?

Owners: Remove pagination

Anything else apart from pagination? :)

Threshold: Change text

Sorry, I don't understand this point

Consistent height of settings options

Totally makes sense for screens with height smaller than the default, just to mention that if we remove pagination from the owner list, this page could have a bigger height.

[lukasschor]

I assume we do this with notifications #135

Yes, added more info in the spec

There are no designs for this. Is it a different page or just a notification in the bottom right corner?
What would be the exact text to show?

Yes, added more info in the spec

Anything else apart from pagination? :)

Sorry, I don't understand this question. :P

Sorry, I don't understand this point

In the "Name Settings" the text takes the entire width of the card, in the "Threshold settings" there is a line-break roughly in the middle of the card. This should be removed and the text should basically just be one line.

Totally makes sense for screens with height smaller than the default, just to mention that if we remove pagination from the owner list, this page could have a bigger height.

Yes, I think that's fine 👍

[germartinez]

Sorry, I don't understand this question. :P

This is the text below the title Owners: Remove pagination:
"Remove pagination and"
I just thought that maybe there was something else that was accidentally deleted

In the "Name Settings" the text takes the entire width of the card, in the "Threshold settings" there is a line-break roughly in the middle of the card. This should be removed and the text should basically just be one line

Thanks 👍

[lukasschor]

Oh, I guess I wanted to say -> ... and change text to : "Any transaction requires the confirmation of:"

Because it current mentiones the daily limit, whereas the daily limit is not yet implemented.