Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Transaction list #79

Closed
tschubotz opened this issue Oct 18, 2018 · 0 comments
Closed

Transaction list #79

tschubotz opened this issue Oct 18, 2018 · 0 comments
Assignees

Comments

@tschubotz
Copy link
Member

tschubotz commented Oct 18, 2018

Story
As a user I am able to see all transactions affecting my Safe including their status in order to know what's going on with my Safe.

Acceptance criteria
ui v1 1 -6 safes transactions

  • Transactions are sorted by nonce, descending.
  • User can sort by other columns as well.
  • User can filter by "type"
    • Modify settings: Anything we identify as tx that changes the Safe settings, i.e. add/remove/replace owners, change threshold.
    • Incoming transfer: Incoming ETH transfer (no data) or incoming ERC-20 token transfer.
    • Outgoing transfer: Outgoing ETH transfer (no data) or Outgoing ERC-20 token transfer.
    • TODO: How do we handle other txs? Most likely they will be called "Data transaction": All other transactions containing data and not fitting into the above categories
  • User can filter by "Status"
    • Awaiting: Waiting for signatures of owners
    • Pending: Submitted to blockchain, waiting for executing/mining
    • Success: Successfully executed / mined
    • Failed: Execution failed
  • Which Date to use?
    • Awaiting: Date of the initial creation of the tx with the tx history service
    • Pending: Submission timestamp
    • Success: Mining timestamp
    • Failed: Failed timestamp

Details
ui v1 1 -6 safes transactions expand

  • Clicking a row opens transaction details
  • Clicking tx hashes and owner addresses opens Etherscan
  • User can confirm tx or trigger a cancel tx
    [UI] v1.1 -6. Safes [Transactions] > Expand > CONFIRM TX.png
    [UI] v1.1 -6. Safes [Transactions] > Expand > CONFIRM TX > CONFIRMED.png
    [UI] v1.1 -6. Safes [Transactions] > Expand > CANCEL TX.png

Things that are open / need to be discussed:

  • How to handle and display transactions with the same nonce?
@tschubotz tschubotz mentioned this issue Oct 24, 2018
@lukasschor lukasschor self-assigned this Apr 10, 2019
@lukasschor lukasschor added this to the MVP milestone May 6, 2019
@lukasschor lukasschor assigned mmv08 and unassigned lukasschor Jun 19, 2019
mmv08 added a commit that referenced this issue Jul 18, 2019
@mmv08 mmv08 closed this as completed Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants