Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Feature: Add liquity app #2151

Merged
merged 6 commits into from
Apr 20, 2021
Merged

Feature: Add liquity app #2151

merged 6 commits into from
Apr 20, 2021

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Apr 9, 2021

This PR:

  • Add liquity app

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

@mmv08
Copy link
Member Author

mmv08 commented Apr 9, 2021

We're waiting for the new version of the app with an icon present

@francovenica
Copy link
Contributor

francovenica commented Apr 16, 2021

So I tried this one in Rinkeby
2 times with 1 ETH and 2k debt and both failed
1 time with 5 ETH and 2k debt and it failed
1 time with 10 ETH and 10k debt and It worked and got the LUSD
image.png

Since it worked for 10Eth and 10k debt I will assume that our job of making the app available and workable in the gnosis app is done and it works. Still, I'll leave details of the failed tx

For the first 3 attempts (1ETH and 5ETH) I had the warning that executing the tx could fail, only for the last signing and execution, not for the creation of the tx
Is weird that the app allows me to set 1ETH and 2000 debt to end up failing, but that's on the App side I think

Safe and env: https://pr2151--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/transactions
tx : 931 to 934
931 (failed) : https://rinkeby.etherscan.io/tx/0x999b340c6c628f2c0bee46a1161d636f8c1e417632f6c8c40f3d1a93ea4c4ec7
932 (failed) : https://rinkeby.etherscan.io/tx/0xf764c1283076eb7c24c3320a96c6f05694af7741b8f224c697cb0b4fd4bae608
933 ( failed) : https://rinkeby.etherscan.io/tx/0x32fd16dcb1c99aeff16c9bae7bcf48ddc83769fdf971839a7759f85dec17f95f
934 (sucessful) : https://rinkeby.etherscan.io/tx/0xec5bff91042c2e14a3fdf8d8c9a69c3e05d134887b2494fd331d3663af7a3cc0

Note: didn't test in on Mainnet since it seems you need a ton of ETH to make it work and I don't have those funds and even if I had them I see it as a waste of tokens to test it beyond of what I did in Rinkeby.

Copy link
Contributor

@francovenica francovenica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dasanra I'll approve it, but still give a look at my comment if you will.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@dasanra dasanra merged commit 69cc936 into development Apr 20, 2021
@dasanra dasanra deleted the feature/add-liquity-app branch April 20, 2021 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants