-
Notifications
You must be signed in to change notification settings - Fork 363
Use Gateway SDK for most of the gateway calls #2522
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
[warning] @typescript-eslint/explicit-module-boundary-types
Report generated by eslint-plus-action |
Definitely a regression. Update: I couldn't reproduce this. The API might have been down? |
Sorry, I forgot the link. It works fine on the Release branch #2535 |
0d5ac26
to
46940b5
Compare
@francovenica fixed! ✅ |
Works fine now |
@dasanra the combination of a GitHub package (@gnosis.pm/safe-react-gateway-sdk) and a prepare script that builds it was breaking our yarn install. Some googling revealed that it's due to network concurrency when installing dependencies for both the main and the SDK package. So I had to add this line, which fixed the problem: https://github.com/gnosis/safe-react/pull/2522/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R36 This might shoot us in the foot in some unexpected way, so please be aware of it. |
This will make the depedency install very slow, apparently, it only happens if the package is published on GitHub. Can we maybe release it to npm? |
@mikheevm it seems that changing cache folder fix only works when you have 1 package causing conflicts. We can have either safe-react-components or safe-react-gateway-sdk referencing a direct commit on github but not both 😉 For now I published a new version with latest safe-react-components and we will publish a new one of the sdk when we close the current changes 👍 |
ESLint Summary View Full Report
[warning] @typescript-eslint/explicit-module-boundary-types
Report generated by eslint-plus-action |
What it solves
Resolves #2505.
How this PR fixes it
Replaces some of the endpoints with the new Gateway SDK.
Namely:
How to test it
Load a safe, check assets and collectibles. Open the currency menu.