Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Don't show required error when loading a safe #2574

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

juampibermani
Copy link
Contributor

What it solves

Resolves #2539

How this PR fixes it

Initializes the safeName variable with undefined so the required check is not made

How to test it

-Open Add existing safe

The required error should be ther

@juampibermani juampibermani added this to the 3.11.0 milestone Jul 22, 2021
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 1 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 1 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@francovenica
Copy link
Contributor

Looks good to me

@mmv08
Copy link
Member

mmv08 commented Jul 23, 2021

Should it rather check if the field was touched?

@dasanra dasanra removed this from the 3.11.0 milestone Jul 26, 2021
@dasanra
Copy link
Collaborator

dasanra commented Jul 26, 2021

@mikheevm I think that with this change we are restoring the previous behavior and it already does what you say. Once the input is touched is set to '' and so if the user leaves it empty the error is shown.

@dasanra dasanra merged commit ffcbe90 into dev Jul 26, 2021
@dasanra dasanra deleted the fix/2539-required-error-on-safe-name-when-loading-safe branch July 26, 2021 15:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "required" is displayed for the safe name when Add safe is opened
4 participants