Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Docs: app environments and deployments #3816

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Docs: app environments and deployments #3816

merged 3 commits into from
Apr 26, 2022

Conversation

katspaugh
Copy link
Member

Docs on how we work on features and which environments we use.

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Apr 26, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

coveralls commented Apr 26, 2022

Pull Request Test Coverage Report for Build 2225402614

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 35.774%

Totals Coverage Status
Change from base Build 2221491027: 0.0%
Covered Lines: 3566
Relevant Lines: 9036

💛 - Coveralls

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very informative! I have a few small suggestions

docs/environments.md Show resolved Hide resolved
|release PRs|`https://pr<PR_NUMBER>--safereact.review-safe.gnosisdev.com/app`|pre-release regression testing|in PRs to `main`|**production** (sic!)|
|dev |https://safe-team.dev.gnosisdev.com/app/|preview of all WIP features|on push to the `dev` branch|staging|
|staging|https://safe-team.staging.gnosisdev.com/app/|preview of features before a release|on push to `main`|staging|
|production|https://gnosis-safe.io/app/|live app|deployed by devops (see the [Release Procedure](https://github.com/safe-global/safe-react/blob/ee39ef932d58e67db96756577814c1bfaf396d75/docs/release-procedure.md))|**production**|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|production|https://gnosis-safe.io/app/|live app|deployed by devops (see the [Release Procedure](https://github.com/safe-global/safe-react/blob/ee39ef932d58e67db96756577814c1bfaf396d75/docs/release-procedure.md))|**production**|
|production|https://gnosis-safe.io/app/|live app|deployed by DevOps (see the [Release Procedure](https://github.com/safe-global/safe-react/blob/ee39ef932d58e67db96756577814c1bfaf396d75/docs/release-procedure.md))|**production**|

As well as other mentions of 'devops' here.

docs/environments.md Outdated Show resolved Hide resolved
docs/environments.md Outdated Show resolved Hide resolved
katspaugh and others added 2 commits April 26, 2022 10:21
Co-authored-by: Aaron Cook <aaron.cook@gnosis.pm>
Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Should we also add a section on how we handle hotfixes?

@katspaugh
Copy link
Member Author

@usame-algan this doc inventorizes environments, how we use them and why we need them.

The hotfix procedure can be added here: https://github.com/safe-global/safe-react/blob/dev/docs/release-procedure.md
That doc currently just says "create a release branch" w/o specifying how. A regular release would be from dev, a hot fix would be from main + cherry-picked commits.

@katspaugh katspaugh merged commit 85636c0 into dev Apr 26, 2022
@katspaugh katspaugh deleted the docs branch April 26, 2022 08:33
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants