Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Feat: add mobile banner on Dashboard #3853

Merged
merged 5 commits into from
May 6, 2022
Merged

Feat: add mobile banner on Dashboard #3853

merged 5 commits into from
May 6, 2022

Conversation

katspaugh
Copy link
Member

What it solves

  • Reuse Card styles
  • Use a theme color instead of #fff
  • Move components from the Home route to the Dashboard component

@github-actions
Copy link

github-actions bot commented May 4, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@katspaugh katspaugh changed the title Refactor: Refactor: dashboard safe apps May 4, 2022
@github-actions
Copy link

github-actions bot commented May 4, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

coveralls commented May 4, 2022

Pull Request Test Coverage Report for Build 2268952042

  • 0 of 13 (0.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 35.38%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Dashboard/SafeApps/DashboardAppCard.tsx 0 1 0.0%
src/routes/Home/index.tsx 0 1 0.0%
src/components/Dashboard/index.tsx 0 2 0.0%
src/components/Dashboard/SafeApps/index.tsx 0 4 0.0%
src/components/Dashboard/styled.tsx 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/Dashboard/PendingTxs/PendingTxsList.tsx 1 0%
Totals Coverage Status
Change from base Build 2268363536: -0.02%
Covered Lines: 3601
Relevant Lines: 9235

💛 - Coveralls

@katspaugh katspaugh requested a review from usame-algan May 4, 2022 09:42
@github-actions
Copy link

github-actions bot commented May 4, 2022

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've noticed that only the centre of the cards are clickable but I don't think it's an issue.

card

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

* Feat: add mobile banner on Dashboard

* Preload next slide

* Add a back button

* Move events

* Track all banner clicks

* Appstore link

* Move banner to the top

* Add links to nfts and tokens

* Empty title placeholders

* Move tx queue to the top when banner is closed; flatten featured apps

* Stretch featured app card

* Cursor pointer only on Learn More

* Undo the stretching of Featured Apps
@katspaugh katspaugh changed the title Refactor: dashboard safe apps Feat: add mobile banner on Dashboard May 6, 2022
@katspaugh katspaugh merged commit 53394a6 into dev May 6, 2022
@katspaugh katspaugh deleted the dashboard-mobile branch May 6, 2022 06:28
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants