Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont duplicate conditions #242

Closed
MrSwitch opened this issue Aug 4, 2022 · 1 comment · Fixed by #243
Closed

Dont duplicate conditions #242

MrSwitch opened this issue Aug 4, 2022 · 1 comment · Fixed by #243
Labels
released

Comments

@MrSwitch
Copy link
Member

MrSwitch commented Aug 4, 2022

Subquery conditions are being erroneously duplicated. Whilst this doesn't lead to problems it does make the SQL slightly harder to read and is redundant.
MrSwitch added a commit that referenced this issue Aug 4, 2022
@MrSwitch
fix(join): dont duplicate join conditions in subquery, fixes #242
145d7e3
@MrSwitch MrSwitch mentioned this issue Aug 4, 2022
Merged
MrSwitch added a commit that referenced this issue Aug 4, 2022
@MrSwitch
Merge pull request #243 from 5app/242-fix-duplicate-conditions
9f2fa86 
fix(join): dont duplicate join conditions in subquery, fixes #242
5app-Machine added a commit that referenced this issue Aug 4, 2022
@5app-Machine
chore(release): 0.66.1 [skip ci]
8d4fd51 
## [0.66.1](v0.66.0...v0.66.1) (2022-08-04)

### Bug Fixes

* **join:** dont duplicate join conditions in subquery, fixes [#242](#242) ([145d7e3](145d7e3))
@5app-Machine
Copy link
Contributor

🎉 This issue has been resolved in version 0.66.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(join): dont duplicate join conditions in subquery, fixes #242 5app/dare
2 participants
@MrSwitch @5app-Machine