Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not mutate filter object #91

Closed
MrSwitch opened this issue Sep 24, 2019 · 1 comment
Closed

Should not mutate filter object #91

MrSwitch opened this issue Sep 24, 2019 · 1 comment
Labels

Comments

@MrSwitch
Copy link
Member

The filter object is mutated where there is an empty array. Objects should be treated as immutable.

e.g.

const filter = {value: []};
dare.get('table', ['name'], filter);
console.log(filter.value); // [null]
console.log(filter.value.length); // 1
MrSwitch pushed a commit that referenced this issue Sep 25, 2019
## [0.32.3](v0.32.2...v0.32.3) (2019-09-25)

### Bug Fixes

* **filters:** prevent dare from modifying input filters, fixes [#91](#91) ([6c763dc](6c763dc))
@MrSwitch
Copy link
Member Author

🎉 This issue has been resolved in version 0.32.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant