Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Misc. Incorrect Monster Data #314

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

Redmega
Copy link
Contributor

@Redmega Redmega commented Oct 27, 2020

What does this do?

Fixes some mismatched data between the SRD and what exists in the DB

How was it tested?

CI/CD

Is there a Github issue this is resolving?

No, this was reported on our site

Did you update the docs in the API? Please link an associated PR if applicable.

No docs to update

Here's a fun image for your troubles

random photo - update me

@Redmega
Copy link
Contributor Author

Redmega commented Oct 27, 2020

Horned Devil:
Screenshot from 2020-10-27 11-35-59

Wight:
Screenshot from 2020-10-27 11-38-22

@ogregoire
Copy link
Collaborator

Note, it might be good at some point to reformat the file properly. Too many "damage_immunities": ["fire", "whatever"] exist and aren't properly formatted.

@Redmega
Copy link
Contributor Author

Redmega commented Oct 27, 2020

aren't properly formatted

Are you referring to them not being APIResource docs w/ url, etc?

@ogregoire
Copy link
Collaborator

That crossed my mind as well, but I was more literal by thinking about pure formatting and indentation.

@bagelbits
Copy link
Collaborator

@ogregoire For the most part, I have an autoformatter handle it but having any kind of standard configuration on it wouldn't be a terrible idea.

@bagelbits
Copy link
Collaborator

#246 is for figuring out how to handle API Resources for that. The "whatever" is the troubling part of that.

Copy link
Collaborator

@bagelbits bagelbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bagelbits bagelbits merged commit 99d770d into 5e-bits:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants