-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python script for FTP connection and Dockerfile #2
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script will be part of our "production" code. We will have to ensure its quality.
Please address the requested changes (comments)
count=0 | ||
result={} | ||
|
||
ftp.cwd('tests') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'tests' should be a variable that we can easily change. Shouldn't be hardcoded
|
||
result["Total Tests"] = count | ||
|
||
x=requests.post(urlManager, result) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agents will have to authenticate themselves on the CI/CD Manager.
We will have to deal with these authentication mechanisms. Authenticate the Agent, check if the token is expired, etc...
Now with a more lightweight image, the configurations are specified in "envfile", having to later run the container with " ... --env-file=(path/to/envfile) ..." |
…envfile, no token verification) and ready to POST test descriptions
After running the docker image, the cron job only starts after running "cron" in the container, despite it being in the dockerfile.
Change IP addresses for different FTP and HTTP Servers.