Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies: pre-commit and python-publish #84

Merged
merged 10 commits into from
Aug 30, 2022

Conversation

antonagestam
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 29, 2022

File Coverage Lines Branches Missing
All files 93% 96% 91%
bananas/__init__.py 79% 83% 75% 19-20
bananas/environment.py 98% 97% 100% 223 229 232
bananas/models.py 98% 100% 96%
bananas/url.py 97% 100% 95%
bananas/admin/extension.py 94% 100% 88%
bananas/admin/api/i18n.py 91% 83% 100% 11
bananas/admin/api/mixins.py 71% 75% 67% 86 94-102 113 129 139-150
bananas/admin/api/serializers.py 91% 100% 83%
bananas/admin/api/versioning.py 93% 100% 87%
bananas/admin/api/views.py 99% 98% 100% 137
bananas/admin/api/schemas/base.py 91% 83% 100% 11
bananas/admin/api/schemas/yasg.py 90% 95% 86% 92 101 140-141
bananas/drf/fencing.py 91% 94% 87% 91-97 136
bananas/management/commands/syncpermissions.py 89% 95% 83% 32

Minimum allowed coverage is 85%

Generated by 🐒 cobertura-action against 264a2e2

@antonagestam
Copy link
Contributor Author

Ouff, type checking is thoroughly broken, I suspect much of it is due to the fixes of managers in django-stubs.

Copy link
Contributor

@flaeppe flaeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a minor suggestion, no blocker

tests/project/models.py Outdated Show resolved Hide resolved
tests/project/models.py Outdated Show resolved Hide resolved
@flaeppe
Copy link
Contributor

flaeppe commented Aug 30, 2022

This PR should also supersede #83

@antonagestam
Copy link
Contributor Author

Thanks for the review @flaeppe, I updated to build the managers from Manager :)

Copy link
Contributor

@flaeppe flaeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@antonagestam antonagestam merged commit b187620 into master Aug 30, 2022
@antonagestam antonagestam deleted the chore/bump-dependencies branch August 30, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants