Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method to delete a person on churchtools #91

Merged
merged 6 commits into from
Aug 23, 2022

Conversation

stollr
Copy link
Collaborator

@stollr stollr commented Aug 22, 2022

As a follow up to #84 I'd like to add a method to call the API endpoint to delete a person record.

It is quite simple to use:

use CTApi\Requests\PersonRequest;

$personA = PersonRequest::find(21);
PersonRequest::delete($personA);

I haven't added documentation or unit tests, because your way of writing those is a bit hard to follow for me :-)
It would be nice if you could do that.

@stollr
Copy link
Collaborator Author

stollr commented Aug 22, 2022

Argh... the last commit message should have been "Updated CHANGELOG"... sorry

@stollr
Copy link
Collaborator Author

stollr commented Aug 22, 2022

Fixed by force push ^^

@DumbergerL
Copy link
Contributor

@Naitsirch No Problem! I admit it's a little hard to understand. I've added the documentation.

I split it up into several commit to improve the readability:

  1. create example-code in "Tests\Unit\DocsPersonRequestTest" 01a6c75
  2. add Unit-Test-Method to documentation in Folder docs/src/ressources/PersonAPI.md 33e5e8e
  3. generate the docs with the composer run-script docs-generator command => this will create the documentation with the code example in Folder docs/out/PersonAPI.md 7e70a52

I hope this helps!

@DumbergerL DumbergerL merged commit bca5ced into 5pm-HDH:master Aug 23, 2022
@stollr stollr deleted the delete_person branch August 24, 2022 20:39
@DumbergerL DumbergerL mentioned this pull request Aug 26, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants