Make API types clonable #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dmweis , I like it! Deriving |
64bit
approved these changes
Mar 12, 2023
|
Awesome! Thanks! |
|
Thank you for the PR, this is released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I originally only wanted to make
Usageclonable because I was trying to pass it around and realise you can't clone it.But looking at it I noticed that a lot of the API types don't have clone so I added it because it makes working with them easier.
I think some of them could even do with copy since they can be bitwise copied but didn't want to go around randomly adding things that I didn't need yet.
Let me know what you think! Happy to remove a lot of these clones if if you think I put them on types that shouldn't have them!